Fix small remarks #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonard-Pat
reviewed
Jun 6, 2024
Comment on lines
+99
to
+101
|
|
||
| fn compute_max_fee_v3(mut resource_bounds: Span<ResourceBounds>, tip: u128) -> u128 { | ||
| let mut max_fee: u128 = 0; |
There was a problem hiding this comment.
why move from the utils ?
There was a problem hiding this comment.
Thought it can be part of the account now that we reduced its code and doesn't need to be shared anymore
Leonard-Pat
reviewed
Jun 6, 2024
| assert(max_fee.into() < amount, 'gift-fac/fee-too-high'); | ||
|
|
||
| let sender = get_caller_address(); | ||
| let factory = get_contract_address(); | ||
| // TODO We could manually serialize for better performance | ||
| // TODO pubkey can be zero? |
sgc-code
approved these changes
Jun 6, 2024
Leonard-Pat
approved these changes
Jun 6, 2024
|
Don't merge please |
|
Fixing tests |
|
Done (but one that should be fixed with Leo's PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing some remarks